Skip to content

fix(es/types): add new options types#11683

Open
SukkaW wants to merge 1 commit intoswc-project:mainfrom
SukkaW:fix-types
Open

fix(es/types): add new options types#11683
SukkaW wants to merge 1 commit intoswc-project:mainfrom
SukkaW:fix-types

Conversation

@SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Mar 14, 2026

Description:

#11493 lands unsafe_hoist_static_method_alias and unsafe_hoist_global_objects_alias options, but @swc/types is not updated.

The PR fixes that.

BREAKING CHANGE:

N/A

Related issue (if exists):

#9741
#11493

@SukkaW SukkaW requested a review from a team as a code owner March 14, 2026 11:44
Copilot AI review requested due to automatic review settings March 14, 2026 11:44
@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2026

⚠️ No Changeset found

Latest commit: 63bd04f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI reviewed Mar 14, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the public TypeScript types for SWC’s terser-compatible minifier config so consumers can use newly supported unsafe hoisting options without type errors.

Changes:

  • Add unsafe_hoist_static_method_alias?: boolean to TerserCompressOptions.
  • Add unsafe_hoist_global_objects_alias?: boolean to TerserCompressOptions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2026

Binary Sizes

File Size
swc.linux-x64-gnu.node 28M (28750152 bytes)

Commit: 1d776cb

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 14, 2026

Merging this PR will not alter performance

✅ 219 untouched benchmarks

Comparing SukkaW:fix-types (63bd04f) with main (874338b)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (4eab592) during the generation of this report, so 874338b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SukkaW